Copilot commented on code in PR #65983:
URL: https://github.com/apache/doris/pull/65983#discussion_r3642744364
##########
fe/fe-core/src/main/java/org/apache/doris/cloud/alter/CloudSchemaChangeHandler.java:
##########
@@ -169,7 +169,6 @@ public void updateTableProperties(Database db, String
tableName, Map<String, Str
groupCommitMode, olapTable.getGroupCommitMode());
return;
}
- partitions.addAll(olapTable.getPartitions());
} finally {
olapTable.readUnlock();
}
Review Comment:
This branch now skips updating Meta Service tablet metadata (by not
collecting partitions) for group commit properties. Please add an explicit
comment here to make the intent clear and prevent accidental reintroduction of
per-tablet UpdateTablet RPCs.
This issue also appears on line 362 of the same file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
