github-actions[bot] commented on code in PR #61518:
URL: https://github.com/apache/doris/pull/61518#discussion_r3637906466
##########
be/src/cloud/cloud_internal_service.cpp:
##########
@@ -1230,7 +1236,9 @@ void
CloudInternalServiceImpl::warm_up_rowset(google::protobuf::RpcController* c
.ctx = {.is_index_data = false,
.expiration_time = expiration_time,
.is_dryrun =
config::enable_reader_dryrun_when_download_file_cache,
- .is_warmup = true},
+ .is_warmup = true,
+ .table_name = "",
Review Comment:
[P2] Attribute blocks created by local warmup
This and the sibling sync/periodic warmup and index-preload paths perform
real cache fills with both new fields empty even though the producer already
knows the tablet ID. `FILE_CACHE_INFO` emits only the persisted name strings,
and `add_cell()` records context only when the cell is created, so a later
named OLAP scan merely hits the anonymous cell and cannot repair it. This is
distinct from the peer/hot-redistribution threads: these local paths start
without context. Please propagate stable identity from the known tablet, or
safely late-bind the first named hit, and cover warm-before-query rows in
`FILE_CACHE_INFO`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
