github-actions[bot] commented on code in PR #65647:
URL: https://github.com/apache/doris/pull/65647#discussion_r3627145585
##########
fs_brokers/cdc_client/src/main/java/org/apache/doris/cdcclient/source/reader/mysql/MySqlSourceReader.java:
##########
@@ -1018,6 +1019,13 @@ private MySqlSourceConfig generateMySqlConfig(
// Keep genuinely ancient (<100) DATE/DATETIME years; MySQL already
completes 2-digit years.
dbzProps.setProperty("enable.time.adjuster", "false");
+ // The converter is valid only when snapshot JDBC exposes YEAR values
as numbers.
Review Comment:
**[P1] Parse Connector/J's effective boolean before gating this converter**
Connector/J accepts both `FALSE` and `NO` as false boolean values. Because the
FE normalizer preserves any explicit `yearIsDateType` value, a valid URL ending
in `yearIsDateType=NO` configures numeric snapshot reads, but this literal
comparison leaves the custom converter disabled. Debezium's default YEAR path
then adjusts source YEAR 0 to 2000 in snapshot and 1900 in binlog instead of
preserving 0. Please gate on Connector/J's parsed boolean value (or otherwise
canonicalize all supported false spellings) and add `NO` snapshot/binlog
coverage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
