github-actions[bot] commented on code in PR #65620:
URL: https://github.com/apache/doris/pull/65620#discussion_r3594510975
##########
regression-test/suites/fault_injection_p0/partial_update/test_partial_update_skip_compaction.groovy:
##########
@@ -166,8 +177,19 @@ suite("test_partial_update_skip_compaction",
"nonConcurrent") {
// let the partial update load publish
disable_block_in_publish()
+ disable_publish_spin_wait()
Review Comment:
In cloud mode this removes the outer spin point before the load thread is
joined, but `CloudGlobalTransactionMgr` reads it with `isEnable(...)` followed
by a separate `getDebugPoint(...)` and unconditionally dereferences the result.
If removal lands between those calls, the insert gets a `NullPointerException`
instead of being released. Keep the spin point installed until after
`t1.join()` (remove only the block first), or make the FE lookup
atomic/null-safe.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]