github-actions[bot] commented on code in PR #65453:
URL: https://github.com/apache/doris/pull/65453#discussion_r3593556392
##########
regression-test/suites/inverted_index_p0/analyzer/test_custom_analyzer.groovy:
##########
@@ -461,9 +461,9 @@ suite("test_custom_analyzer", "p0") {
qt_sql """ select tokenize("BAR", '"analyzer"="lowercase_delimited"'); """
sql """ alter table ${indexTbName1} add index idx_ch_default(`ch`) using
inverted; """
- wait_for_last_build_index_finish("${indexTbName1}", 60000)
+ wait_for_last_col_change_finish("${indexTbName1}", 60000)
Review Comment:
In non-Cloud mode an `INVERTED` add is a light metadata change, so the row
inserted above is not backfilled by either of these changed column waits.
Because missing-index MATCH fallback is enabled by default, the assertions
below can scan and pass without ever exercising a custom-analyzer index file.
This is a separate instance from the partition-drop thread: please explicitly
`BUILD INDEX` and snapshot/wait for both new indexes in non-Cloud before
running these MATCH queries; the Cloud schema-change path can keep the column
wait.
##########
regression-test/plugins/plugin_index_change.groovy:
##########
@@ -51,25 +73,28 @@ Suite.metaClass.build_index_on_table = {index_name,
table_name ->
}
Suite.metaClass.wait_for_last_col_change_finish = { table_name, OpTimeout ->
- def useTime = 0
+ def finished = false
+ def alter_res = ""
- for (int t = delta_time; t <= OpTimeout; t += delta_time) {
- def alter_res = sql """SHOW ALTER TABLE COLUMN WHERE TableName =
"${table_name}" ORDER BY CreateTime DESC LIMIT 1;"""
+ for (int t = 0; t <= OpTimeout; t += delta_time) {
+ alter_res = sql """SHOW ALTER TABLE COLUMN WHERE TableName =
"${table_name}" ORDER BY CreateTime DESC LIMIT 1;"""
alter_res = alter_res.toString()
if (alter_res.contains("FINISHED")) {
Review Comment:
The column waiter still treats a terminal `CANCELLED` job like a transient
state. Once the latest column job is cancelled, every caller keeps issuing
`SHOW` and sleeping until its full timeout; `test_index_change_4` passes 300000
here, so the real failure can be delayed by five minutes. Please fail
immediately on the exact cancelled state and include the current row/error, as
the new build-index waiter already does.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
