github-actions[bot] commented on code in PR #65657:
URL: https://github.com/apache/doris/pull/65657#discussion_r3588308582
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/logical/LogicalOlapTableStreamScan.java:
##########
@@ -276,11 +276,11 @@ public LogicalOlapTableStreamScan
withSelectedPartitionIds(List<Long> selectedPa
*/
@Override
public LogicalOlapTableStreamScan withSelectedPartitionIds(List<Long>
selectedPartitionIds,
- boolean
isPartitionPruned) {
+ boolean
hasPartitionPredicate) {
return AbstractPlan.copyWithSameId(this, () ->
new LogicalOlapTableStreamScan(relationId, (Table) table,
qualifier,
groupExpression, Optional.of(getLogicalProperties()),
- selectedPartitionIds, isPartitionPruned,
hasPartitionPredicate, selectedTabletIds,
+ selectedPartitionIds, true, hasPartitionPredicate,
selectedTabletIds,
Review Comment:
This fixes the flag on the stream scan itself, but it still gets lost before
execution. `NormalizeOlapTableStreamScan` lowers the stream into fresh
`LogicalOlapScan` children by passing the internally selected stream partitions
to the `specifiedPartitions` constructor. Those children start with
`partitionPruned=false` and non-empty `manuallySpecifiedPartitions`, so the
next top-down pruning pass treats them like user-specified partitions and sets
`hasPartitionPredicate=true` even for `SELECT * FROM stream` with no partition
filter. That value is copied to `OlapScanNode`, passed by
`StmtExecutor.checkBlockRulesByScan` into `SqlBlockRuleMgr.checkLimitations`,
and used by the `rule.getRequirePartitionFilter()` check, so such stream
queries can bypass a required partition-filter block rule. The normalized
base/binlog scans need to preserve `scan.hasPartitionPredicate()` instead of
reclassifying internal partition ids as manual predicates.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
