shuke987 commented on code in PR #65453:
URL: https://github.com/apache/doris/pull/65453#discussion_r3587173469
##########
regression-test/suites/inverted_index_p0/index_change/test_drop_index_on_partition.groovy:
##########
@@ -76,7 +76,7 @@ suite("test_drop_index_on_partition", "inverted_index") {
// create inverted index
sql "CREATE INDEX idx_v2 ON ${tableName1}(v2) USING INVERTED"
- wait_for_last_build_index_finish(tableName1, timeout)
+ wait_for_last_col_change_finish(tableName1, timeout)
Review Comment:
Fixed in 7e4bb8f9337. The partition-drop helper now uses an explicit
finished flag, fails immediately on CANCELLED, requires the expected job count
and all rows FINISHED, and reports the latest result on timeout.
##########
regression-test/suites/inverted_index_p0/index_change/test_index_change_on_renamed_column.groovy:
##########
@@ -100,8 +100,12 @@ suite("test_index_change_on_renamed_column") {
check_nested_index_file(ip, port, tablet_id, 3, 1, "V3")
// drop inverted index on renamed column
+ def previous_job_ids = isCloudMode() ? get_build_index_job_ids(tableName)
: null
sql """ alter table ${tableName} drop index idx_s; """
- wait_for_last_build_index_finish(tableName, timeout)
+ wait_for_last_col_change_finish(tableName, timeout)
Review Comment:
Fixed in 7e4bb8f9337. The renamed-column non-cloud explicit build now
snapshots existing JobIds and reuses the shared strict new-job helper; the
flawed local helper was removed.
##########
regression-test/suites/inverted_index_p0/index_change/test_index_change_on_renamed_column.groovy:
##########
@@ -100,8 +100,12 @@ suite("test_index_change_on_renamed_column") {
check_nested_index_file(ip, port, tablet_id, 3, 1, "V3")
// drop inverted index on renamed column
+ def previous_job_ids = isCloudMode() ? get_build_index_job_ids(tableName)
: null
sql """ alter table ${tableName} drop index idx_s; """
- wait_for_last_build_index_finish(tableName, timeout)
+ wait_for_last_col_change_finish(tableName, timeout)
+ if (isCloudMode()) {
+ wait_for_last_build_index_finish(tableName, timeout, previous_job_ids)
Review Comment:
Fixed in 7e4bb8f9337. Because this suite sets
enable_add_index_for_new_data=false, the drop now keeps only the column/schema
wait and no longer expects new build-index rows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
