github-actions[bot] commented on code in PR #65636:
URL: https://github.com/apache/doris/pull/65636#discussion_r3586899943
##########
fe/fe-core/src/main/java/org/apache/doris/catalog/stream/BaseTableStream.java:
##########
@@ -81,8 +81,8 @@ public static TBinlogScanType toThrift(StreamScanType
streamScanType) {
@SerializedName("sir")
protected boolean showInitialRows;
- @SerializedName("sti")
- protected StreamTableInfo streamTableInfo;
+ @SerializedName("bti")
Review Comment:
This field is persisted in stream table JSON, so changing the serialized key
from `sti` to `bti` without an alternate breaks existing stream tables on
image/load or create-table edit-log replay. Those records still contain `sti`;
with the new annotation Gson leaves `baseTableInfo` null, and the first call to
`getBaseTableNullable()` after restart/replay dereferences it. Please keep the
new name compatible, e.g. `@SerializedName(value = "bti", alternate =
{"sti"})`, and add a legacy-JSON test that deserializes an `OlapTableStream`
containing `sti`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
