github-actions[bot] commented on code in PR #65647: URL: https://github.com/apache/doris/pull/65647#discussion_r3586869009
########## fe/fe-core/src/main/java/org/apache/doris/tablefunction/CdcStreamTableValuedFunction.java: ########## @@ -27,6 +27,7 @@ import org.apache.doris.job.cdc.request.FetchRecordRequest; import org.apache.doris.job.common.DataSourceType; import org.apache.doris.job.extensions.insert.streaming.DataSourceConfigValidator; +import org.apache.doris.job.extensions.insert.streaming.StreamingJdbcUrlNormalizer; import org.apache.doris.job.util.StreamingJobUtils; import org.apache.doris.thrift.TBrokerFileStatus; Review Comment: This normalizes the copy used to build the TVF scan payload, but it does not normalize the TVF job provider path. For `CREATE JOB ... SELECT ... FROM cdc_stream(...)`, `StreamingInsertJob` keeps the original TVF properties and `JdbcTvfSourceOffsetProvider.ensureInitialized()` copies those raw props into `sourceProperties`; `JdbcSourceOffsetProvider` then sends that map to cdcclient for `/api/initReader` and `/api/fetchSplits`. On the cdcclient side, `MySqlSourceReader` parses `jdbc_url` and passes its query properties into Flink CDC `jdbcProperties`, so a TVF job whose URL is just `jdbc:mysql://...` can still initialize/split with Connector/J defaults while the later scan payload is normalized. Please normalize the effective TVF provider properties too, and add/extend a `CREATE JOB ... FROM cdc_stream` MySQL regression with `tinyint(1)` non-boolean values and YEAR 0; the current TVF job test only selects `name, age`, so it cannot catch this path. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
