suxiaogang223 commented on code in PR #65253:
URL: https://github.com/apache/doris/pull/65253#discussion_r3586667146
##########
be/src/format/transformer/vorc_transformer.cpp:
##########
@@ -510,16 +573,13 @@ bool VOrcTransformer::_collect_column_bounds(const
orc::ColumnStatistics* col_st
} else if (const auto* decimal_stats =
dynamic_cast<const
orc::DecimalColumnStatistics*>(col_stats)) {
if (decimal_stats->hasMinimum() && decimal_stats->hasMaximum()) {
- has_bounds = true;
(*lower_bounds)[field_id] =
_decimal_to_bytes(decimal_stats->getMinimum());
Review Comment:
Fixed in d7d193f4e38. ORC decimal statistics are now rescaled to the Iceberg
field scale and the signed Int128 value is serialized directly as minimal
two\x27s-complement bytes. The regression data now covers a negative
decimal(18,6) bound and trailing-zero scale normalization; the generated output
reports -1234.567890 / 8765.432100 for both ORC and Parquet. Verified on Fedora
with an incremental BE build, test_iceberg_write_stats2 (force-generated output
plus a normal verification rerun), and
test_iceberg_spark_doris_metrics_consistency.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
