deardeng opened a new pull request, #65607:
URL: https://github.com/apache/doris/pull/65607
Pure refactor and cleanup, no behavior change:
1. FrontendServiceImpl.forward() is split into intent-revealing helpers
(validate / shortcut / context / processor / execute). ConnectContext.remove()
and the proxy-query clear callback now run in a finally block instead of only
on the success path.
2. MasterOpExecutor no longer calls waitOnReplaying() for the two group
commit shortcuts. The master answers them without writing a journal, so the
result carries no journal id and waiting on journal 0 is a no-op that only logs
one INFO line per request.
3. GroupCommitManager.tableToBeMap becomes a bounded Guava cache. The
previous ConcurrentHashMap kept an entry per table forever, so dropped tables
leaked. Keys and selection logic are unchanged.
4. DorisFE.parseArgs() now returns the parsed CommandLine, and applying the
-r / --recovery_journal_id / --drop_backends system properties moves into
applyCommandLineOverrides(). Those properties are read by Env and BDBJEJournal,
both of which run well after config init, so applying them after Config.init()
is safe. --version now returns before config init, which DorisFETest covers.
5. FrontendHbResponse.toString() printed processUUID under the "festartTime"
label and never printed feStartTime.
### What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [x] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [x] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [x] No.
- [ ] Yes. <!-- Add document PR link here. eg:
https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should
merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
