github-actions[bot] commented on code in PR #65571:
URL: https://github.com/apache/doris/pull/65571#discussion_r3579005785
##########
be/src/service/http/action/stream_load.cpp:
##########
@@ -786,12 +786,20 @@ Status StreamLoadAction::_process_put(HttpRequest*
http_req,
request.__set_group_commit_mode(ctx->group_commit_mode);
}
+ // Keep cloud_cluster for compatibility with old FEs during rolling
upgrade. New FEs use
Review Comment:
This compatibility fallback still leaves the new direct-to-BE behavior
version-dependent. The new regression sends directly to `ipList[0]` while also
setting `compute_group=stream_load_cluster_name1`, and expects the load to use
the receiving BE's compute group. With a new BE talking to an old FE, however,
this request carries both `backend_id` and the legacy `cloud_cluster` copied
from the client header; the old `StreamLoadHandler` branch ignored `backend_id`
for normal password-authenticated loads and planned from
`request.getCloudCluster()`. That means the same direct-to-BE request can still
plan in `stream_load_cluster_name1` during a rolling upgrade instead of binding
to the receiving BE. Please either make the legacy field represent the
receiving BE's compute group for this case, or document/enforce an FE-first
upgrade requirement and cover the mixed-version behavior explicitly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
