CalvinKirs commented on code in PR #65551:
URL: https://github.com/apache/doris/pull/65551#discussion_r3578412420
##########
fe/fe-core/src/test/java/org/apache/doris/httpv2/meta/MetaServiceTest.java:
##########
@@ -0,0 +1,263 @@
+// Licensed to the Apache Software Foundation (ASF) under one
Review Comment:
This is the UT specification, and consistency is recommended.
##########
fe/fe-core/src/main/java/org/apache/doris/master/MetaHelper.java:
##########
@@ -149,7 +149,7 @@ private static void checkFile(File file) throws IOException
{
public static <T> ResponseBody doGet(String url, int timeout, Class<T>
clazz) throws IOException {
Map<String, String> headers = HttpURLUtil.getNodeIdentHeaders();
- LOG.info("meta helper, url: {}, timeout: {}, headers: {}", url,
timeout, headers);
+ LOG.info("meta helper, url: {}, timeout: {}, header names: {}", url,
timeout, headers.keySet());
Review Comment:
I prefer this approach, although it's conservative. If there's a genuine
need to print headers, then it should be handled and intercepted in a public
place.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
