yiguolei commented on code in PR #65324:
URL: https://github.com/apache/doris/pull/65324#discussion_r3577497918
##########
be/src/exec/operator/union_sink_operator.cpp:
##########
@@ -104,38 +104,35 @@ Status UnionSinkOperatorX::sink_impl(RuntimeState* state,
Block* in_block, bool
local_state._output_block =
local_state._shared_state->data_queue.get_free_block(_cur_child_id);
}
+ std::unique_ptr<Block> output_block;
if (_cur_child_id < _get_first_materialized_child_idx()) { //pass_through
if (in_block->rows() > 0) {
local_state._output_block->swap(*in_block);
- RETURN_IF_ERROR(local_state._shared_state->data_queue.push_block(
- std::move(local_state._output_block), _cur_child_id));
+ output_block = std::move(local_state._output_block);
}
Review Comment:
这里感觉缺了一个else
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
