morrySnow commented on code in PR #65539: URL: https://github.com/apache/doris/pull/65539#discussion_r3575789217
########## fe/fe-core/src/main/java/org/apache/doris/catalog/MTMV.java: ########## @@ -44,18 +45,26 @@ import org.apache.doris.mtmv.MTMVRelation; import org.apache.doris.mtmv.MTMVSnapshotIf; import org.apache.doris.mtmv.MTMVStatus; +import org.apache.doris.nereids.DorisParser; +import org.apache.doris.nereids.DorisParserBaseVisitor; +import org.apache.doris.nereids.parser.NereidsParser; import org.apache.doris.nereids.rules.analysis.SessionVarGuardRewriter; import org.apache.doris.qe.ConnectContext; import com.google.common.collect.Maps; import com.google.common.collect.Sets; import com.google.gson.annotations.SerializedName; -import org.apache.commons.collections4.MapUtils; +import org.antlr.v4.runtime.ParserRuleContext; +import org.antlr.v4.runtime.tree.ParseTree; +import org.antlr.v4.runtime.tree.RuleNode; +import org.apache.commons.collections.MapUtils; Review Comment: **Accidental library downgrade**: The import changed from `org.apache.commons.collections4.MapUtils` (commons-collections4 v4.x, the version explicitly declared in `fe/pom.xml`) to `org.apache.commons.collections.MapUtils` (commons-collections v3.x, not declared as a direct dependency). - v4 provides generic type-safe `MapUtils.isEmpty(Map<K,V>)`; v3 takes raw `Map`. - The entire rest of the codebase uses `org.apache.commons.collections4`. - This appears to be an accidental IDE auto-import — the `MapUtils.isEmpty()` calls at lines 781/787 are unchanged and unrelated to the ADD COLUMN feature. **Fix**: Revert this import to `org.apache.commons.collections4.MapUtils`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
