liaoxin01 commented on PR #64148: URL: https://github.com/apache/doris/pull/64148#issuecomment-4959291348
1. The current unit test only covers the two known special cases: `MS_TOO_BUSY` and `KV_TXN_MAYBE_COMMITTED`. If a new `MetaServiceCode` is added later but `legacy_fallback_code()` is not updated, the default branch will return the original code, and old proto2 clients may still parse the unknown enum as unset/OK. Could we add a unit test that iterates all `MetaServiceCode` values and enforces an explicit compatibility decision for each code? Existing codes known by released clients may fallback to themselves; new client-returned codes should map to a legacy-recognizable fallback code; internal-only codes should be explicitly allowlisted with a comment. 2. `preferExactStatusCode()` on the FE side is also key compatibility logic, but I do not see a corresponding unit test. Could we add a Java unit test to cover `code=KV_TXN_CONFLICT, code_exact=MS_TOO_BUSY` being normalized to `MS_TOO_BUSY`, and an unknown `code_exact` falling back to the legacy `code`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
