github-actions[bot] commented on code in PR #65446:
URL: https://github.com/apache/doris/pull/65446#discussion_r3569980146
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/ExportCommand.java:
##########
@@ -92,6 +93,7 @@ public class ExportCommand extends Command implements
NeedAuditEncryption, Forwa
.add(PropertyAnalyzer.PROPERTIES_LINE_DELIMITER)
.add(PropertyAnalyzer.PROPERTIES_TIMEOUT)
.add("format")
+ .add(ParquetFileFormatProperties.ENABLE_INT96_TIMESTAMPS)
Review Comment:
This new EXPORT property needs strict boolean validation before it is
persisted on the job. Right now `checkPropertyKey()` only whitelists the key,
`generateExportJob()` stores the raw string, and replay/execution later feeds
it to `ParquetFileFormatProperties.analyzeFileFormatProperties()`, where
`Boolean.valueOf(...)` silently maps any non-`true` value to `false`. That
means a typo such as `"enable_int96_timestamps" = "flase"` is accepted and
changes the Parquet writer setting instead of failing analysis. Please reject
non-`true`/`false` values on the EXPORT path and add negative coverage for the
invalid value case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
