yujun777 commented on code in PR #65468:
URL: https://github.com/apache/doris/pull/65468#discussion_r3568940149
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/logical/LogicalOlapTableStreamScan.java:
##########
@@ -318,28 +317,31 @@ public LogicalOlapTableStreamScan
withRelationId(RelationId relationId) {
hints, cacheSlotWithSlotName, cachedOutput,
tableSample, directMvScan, colToSubPathsMap,
manuallySpecifiedTabletIds, operativeSlots,
virtualColumns, scoreOrderKeys, scoreLimit,
scoreRangeInfo, annOrderKeys, annLimit, tableAlias,
partitionPrunablePredicates,
- scanParams, isReset, isSnapshot));
+ scanParams, readMode));
}
- /**
- * withIsSnapshot
- */
- public LogicalOlapTableStreamScan withIsSnapshot(boolean isSnapshot) {
+ @Override
Review Comment:
Added in the follow-up commit.
`LogicalOlapTableStreamScan` now overrides `withTableAlias`, and I also
filled the remaining `LogicalOlapScan` rebuild helpers that can still be
reached from stream rewrite paths (`withGroupExprLogicalPropChildren`,
`withMaterializedIndexSelected`, `withColToSubPathsMap`,
`appendVirtualColumns`, `appendVirtualColumnsAndTopN`). They all preserve the
stream node type and `readMode`, so these paths no longer downgrade to plain
`LogicalOlapScan` before `NormalizeOlapTableStreamScan` runs.
I also added aliased `stream@snapshot()` / `stream@reset()` FE UT coverage
in `ExplainTableStreamPlanTest`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
