shuke987 opened a new pull request, #65514:
URL: https://github.com/apache/doris/pull/65514

   ### What problem does this PR solve?
   
   Issue Number: None
   
   Related PR: None
   
   Problem Summary:
   
   A concurrent `ALTER RESOURCE` and `SHOW RESOURCES` can mutate and iterate an 
HDFS resource's `properties` HashMap at the same time, causing 
`ConcurrentModificationException` in FE.
   
   The failure was observed in TeamCity build 991451:
   
http://43.132.222.7:8111/buildConfiguration/Doris_DorisRegression_P0Regression/991451?buildTab=tests&expandedTest=build%3A%28id%3A991451%29%2Cid%3A2000001351
   
   Protect HDFS resource property mutations with the resource write lock, and 
protect property copying and proc-node iteration with the matching read lock. 
Add deterministic unit tests verifying that modification waits for both read 
paths.
   
   ### Release note
   
   None
   
   ### Check List (For Author)
   
   - Test
       - [ ] Regression test
       - [x] Unit Test
       - [ ] Manual test (add detailed scripts or steps below)
       - [ ] No need to test or manual test. Explain why:
           - [ ] This is a refactor/code format and no logic has been changed.
           - [ ] Previous test can cover this change.
           - [ ] No code files have been changed.
           - [ ] Other reason
   
     `DORIS_THIRDPARTY=/Users/keshu/dudu/doris/thirdparty ./run-fe-ut.sh --run 
org.apache.doris.catalog.HdfsResourceTest`
   
     Result: 2 tests run, 0 failures, 0 errors; BUILD SUCCESS.
   
   - Behavior changed:
       - [x] No.
       - [ ] Yes.
   
   - Does this need documentation?
       - [x] No.
       - [ ] Yes.
   
   ### Check List (For Reviewer who merge this PR)
   
   - [ ] Confirm the release note
   - [ ] Confirm test cases
   - [ ] Confirm document
   - [ ] Add branch pick label
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to