github-actions[bot] commented on code in PR #65483:
URL: https://github.com/apache/doris/pull/65483#discussion_r3564895621
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/functions/scalar/BitmapAndCount.java:
##########
@@ -34,7 +35,7 @@
* ScalarFunction 'bitmap_and_count'. This class is generated by
GenerateFunction.
*/
public class BitmapAndCount extends ScalarFunction
- implements ExplicitlyCastableSignature {
+ implements ExplicitlyCastableSignature, AlwaysNotNullable {
Review Comment:
The FE now advertises these bitmap op-count functions as always
non-nullable, but that is only true on BEs that understand
`new_version_bitmap_op_count` and select the new `_v2` functions. In a rolling
upgrade, an older BE ignores the new optional thrift field and still binds the
old `bitmap_and_count` implementation; with nullable bitmap arguments that old
implementation derives `Nullable(BIGINT)` while the new FE plan sends `BIGINT`,
and `FunctionBuilderImpl::build` rejects the mismatch during function
preparation. Please keep the FE nullability compatible until all target BEs can
execute the `_v2` path, or gate the not-null metadata/rewrite on a BE
capability/version check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
