github-actions[bot] commented on code in PR #65459:
URL: https://github.com/apache/doris/pull/65459#discussion_r3563994697
##########
regression-test/suites/external_table_p2/jdbc/test_sqlserver_jdbc_catalog.groovy:
##########
@@ -15,7 +15,7 @@
// specific language governing permissions and limitations
// under the License.
-suite("test_sqlserver_jdbc_catalog", "p0,external") {
+suite("test_sqlserver_jdbc_catalog", "p2,external") {
Review Comment:
This changes the suite to `p2,external`, but the checked-in external
regression stage still runs `testGroups = "external"` with `excludeGroups =
"p1,p2"` (`regression-test/pipeline/external/conf/regression-conf.groovy`). The
framework first matches `external` and then drops any suite whose groups
intersect the exclude set, so this suite and the other moved DB2/SQL
Server/OceanBase/ES/Kerberos cases will be filtered out of `run
external`/`buildall`. I also do not see a wired `p2` or `external_p2` TeamCity
trigger in `teamcity-utils.sh` / `comment-to-trigger-teamcity.yml`, and the
non-external P1 config does not enable these external services. If the intent
is to keep the coverage at P2 frequency, this PR needs to add or wire a P2
external stage/config that enables the same services and does not exclude `p2`,
or keep labels that an existing external stage selects.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
