github-actions[bot] commented on code in PR #65480:
URL: https://github.com/apache/doris/pull/65480#discussion_r3563264971
##########
regression-test/suites/external_table_p0/hive/test_transactional_hive.groovy:
##########
@@ -170,6 +176,8 @@ suite("test_transactional_hive", "p0,external") {
,'fs.defaultFS' = 'hdfs://${externalEnvIp}:${hdfs_port}'
);"""
sql """use `${catalog_name}`.`default`"""
+ sql """set enable_file_scanner_v2 = true;"""
Review Comment:
This does not actually put the ACID reads on ScannerV2. Transactional Hive
ranges are tagged as `transactional_hive` by
`HiveScanRange.Builder.acidInfo()`, but `FileScannerV2::is_supported()` only
allows ORC/Parquet ranges whose table format is `NotSet`, `tvf`, `hive`,
`iceberg`, `paimon`, or `hudi`; `transactional_hive` falls back to the old
`FileScanner` path with `TransactionalHiveReader`. So these new assertions can
still pass while never exercising ScannerV2 for Hive ACID delete predicates.
Please either add/verify V2 transactional-Hive support and assert the selected
scanner in the test profile, or keep this as old-scanner ACID coverage and add
a separate V2 test for the intended path.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
