LuciferYang commented on code in PR #365:
URL:
https://github.com/apache/doris-spark-connector/pull/365#discussion_r3557764355
##########
tools/releasing/deploy_staging_jars.sh:
##########
@@ -61,5 +61,15 @@ ${MVN} clean deploy -Papache-release -DskipTests
-DretryFailedDeploymentCount=10
echo "Deploying spark3.5..."
${MVN} clean deploy -Papache-release -DskipTests
-DretryFailedDeploymentCount=10 -Pspark-3.5 -pl spark-doris-connector-spark-3.5
-am
+# Spark 4.x requires JDK 17 and Scala 2.13 (the modules above target JDK 8).
Set JAVA17_HOME to a
+# JDK 17 home to deploy them with the right toolchain; otherwise the current
JAVA_HOME must be JDK 17.
+SPARK4_MVN_ENV=""
+if [ -n "${JAVA17_HOME:-}" ]; then
+ SPARK4_MVN_ENV="JAVA_HOME=${JAVA17_HOME}"
+fi
Review Comment:
Good catch — done in a3bae8b. Split the Spark 4.x deploy into its own
`deploy_staging_jars_spark4.sh`; `deploy_staging_jars.sh` now covers only the
JDK 8 modules (2.4–3.5). The new script checks `JAVA17_HOME`/`JAVA_HOME` and
the actual `java -version`, and **fails fast** if JDK 17 isn't in effect
instead of silently falling back to JDK 8, so either release flow can be rerun
on its own. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
