morrySnow commented on code in PR #15664:
URL: https://github.com/apache/doris/pull/15664#discussion_r1064148014
##########
fe/fe-core/src/main/antlr4/org/apache/doris/nereids/DorisParser.g4:
##########
@@ -53,11 +57,12 @@ planType
// -----------------Query-----------------
query
- : cte? queryTerm queryOrganization
+ : {!doris_legacy_SQL_syntax}? cte? queryTerm queryOrganization
+ | {doris_legacy_SQL_syntax}? queryTerm
;
queryTerm
- : queryPrimary
#queryTermDefault
+ : queryPrimary
#queryTermDefault
Review Comment:
add back removed blank
##########
regression-test/suites/nereids_syntax_p0/set_operation.groovy:
##########
@@ -242,4 +241,9 @@ suite("test_nereids_set_operation") {
INTERSECT
SELECT k1 FROM setOperationTable WHERE k2 > 0)
"""
+
+ order_qt_select43 """
+ SELECT * FROM (select k1, k3 from setOperationTableNotNullable order
by k3 union all
+ select k1, k5 from setOperationTable) t;
+ """
Review Comment:
add more case, to test all situation of legacy planner's syntax. such as set
operation, w/ and w/o parenthesis, w/ and w/o cte and w/ and w/o query
organization
##########
fe/fe-core/src/main/antlr4/org/apache/doris/nereids/DorisParser.g4:
##########
@@ -70,15 +75,17 @@ setQuantifier
queryPrimary
: querySpecification
#queryPrimaryDefault
| TABLE multipartIdentifier
#table
- | LEFT_PAREN query RIGHT_PAREN
#subquery
+ | LEFT_PAREN query RIGHT_PAREN
#subquery
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
