github-actions[bot] commented on code in PR #64850: URL: https://github.com/apache/doris/pull/64850#discussion_r3519227817
########## regression-test/suites/job_p0/streaming_job/cdc/test_streaming_postgres_job_sc_latest.groovy: ########## @@ -0,0 +1,133 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +import org.awaitility.Awaitility + +import static java.util.concurrent.TimeUnit.SECONDS + +// Verify that schema-change detection works with offset=latest (no snapshot, no JDBC baseline). Review Comment: This says the `offset=latest` case runs with "no JDBC baseline" and that the first Relation establishes the baseline, but the write path does not exercise that. `prepareStreamSplit()` first loads FE `tableSchemas`, and when they are absent it immediately calls `getTableSchemas(baseReq)` and `setTableSchemas(...)` before creating the stream split, so this suite starts with a JDBC-discovered schema baseline. The ADD below is therefore diffed against that discovered baseline, not the `stored == null` Relation-adoption branch in `PostgresDebeziumJsonDeserializer`; if that branch regressed in the job path, this regression would still pass. Please either update the test comments/name to state that it validates the JDBC-discovered `offset=latest` path, or add coverage that actually verifies first-Relation baseline adoption without the `prepareStreamSplit()` discovery fallback. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
