This is an automated email from the ASF dual-hosted git repository.

mrhhsg pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git


The following commit(s) were added to refs/heads/master by this push:
     new 1fa3ca3e317 [chore](be) Refine tablet reader context and generic 
reader handling (#62970)
1fa3ca3e317 is described below

commit 1fa3ca3e31708b483383ba2792127544e10f3065
Author: Jerry Hu <[email protected]>
AuthorDate: Fri Jul 3 17:03:37 2026 +0800

    [chore](be) Refine tablet reader context and generic reader handling 
(#62970)
    
    Issue Number: None
    
    Related PR: None
    
    Problem Summary: Remove unused reader context and generic reader fields
    in the current staged changes so the reader path stays aligned with the
    current output-column and batch-size handling.
    
    None
    
    - Test: No need to test (commit current staged tracked changes only)
    - Behavior changed: No
    - Does this need documentation: No
    
    ### What problem does this PR solve?
    
    Issue Number: close #xxx
    
    Related PR: #xxx
    
    Problem Summary:
    
    ### Release note
    
    None
    
    ### Check List (For Author)
    
    - Test <!-- At least one of them must be included. -->
        - [ ] Regression test
        - [ ] Unit Test
        - [ ] Manual test (add detailed scripts or steps below)
        - [ ] No need to test or manual test. Explain why:
    - [ ] This is a refactor/code format and no logic has been changed.
            - [ ] Previous test can cover this change.
            - [ ] No code files have been changed.
            - [ ] Other reason <!-- Add your reason?  -->
    
    - Behavior changed:
        - [ ] No.
        - [ ] Yes. <!-- Explain the behavior change -->
    
    - Does this need documentation?
        - [ ] No.
    - [ ] Yes. <!-- Add document PR link here. eg:
    https://github.com/apache/doris-website/pull/1214 -->
    
    ### Check List (For Reviewer who merge this PR)
    
    - [ ] Confirm the release note
    - [ ] Confirm test cases
    - [ ] Confirm document
    - [ ] Add branch pick label <!-- Add branch pick label that this PR
    should merge into -->
---
 be/src/format/generic_reader.h | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/be/src/format/generic_reader.h b/be/src/format/generic_reader.h
index 88fc3fb85a0..cc21ce82c28 100644
--- a/be/src/format/generic_reader.h
+++ b/be/src/format/generic_reader.h
@@ -252,10 +252,6 @@ protected:
 
     const size_t _MIN_BATCH_SIZE = 4064; // 4094 - 32(padding)
 
-    // never let batch size be 0 because _do_get_next_block uses it as the
-    // upper bound of a `while (block->rows() < batch_size)` loop and a 0 
would make the reader
-    // return without setting eof, causing the scanner to spin on empty blocks.
-    const size_t _DEFAULT_BATCH_SIZE = 4064; // 4094 - 32(padding)
     TPushAggOp::type _push_down_agg_type {};
 
 public:


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to