morrySnow commented on PR #62737: URL: https://github.com/apache/doris/pull/62737#issuecomment-4873323830
**Correction to review item #6 (RuntimeFilterProducerHelperCross):** After deeper verification, this finding is **REFUTED**. The cross-join path creates VExprContexts for ALL filter descriptors by position (nested_loop_join_build_operator.cpp lines 77-81 create `_filter_src_expr_ctxs` from `_runtime_filter_descs[i].src_expr`), and the Cross `_init_expr` override copies by position rather than indexing by `expr_order`. So a decoupled RF at position `i` correctly gets `_filter_expr_contexts[i]` = expression from desc `i`. The base class approach of indexing by `expr_order` would crash for `expr_order == -1`, but the Cross override avoids this entirely by position-based copying. No bug here. Additionally, finding about `hasFilterInSubtree` missing pushed-down filters is also **REFUTED**: PhysicalFilter nodes are still present in the plan tree during the post-processing phase when `hasFilterInSubtree` runs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
