github-actions[bot] commented on code in PR #65146: URL: https://github.com/apache/doris/pull/65146#discussion_r3511113814
########## regression-test/suites/job_p0/streaming_job/cdc/tvf/test_streaming_job_cdc_stream_mysql_delete_sign.groovy: ########## @@ -0,0 +1,157 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + + +import org.awaitility.Awaitility + +import static java.util.concurrent.TimeUnit.SECONDS + +/** + * Test CDC stream TVF with delete sign enabled for MySQL primary-key table. + * + * Scenario: + * 1. Snapshot phase (offset=initial): pre-existing rows (A1, B1) are synced. + * 2. Incremental INSERT (C1, D1). + * 3. Incremental UPDATE (C1 age -> 30). + * 4. Incremental DELETE (D1 removed). + */ +suite("test_streaming_job_cdc_stream_mysql_delete_sign", "p0,external,mysql,external_docker,external_docker_mysql,nondatalake") { + def jobName = "test_streaming_job_cdc_stream_mysql_ds_name" + def currentDb = (sql "select database()")[0][0] + def dorisTable = "test_streaming_job_cdc_stream_mysql_ds_tbl" + def mysqlDb = "test_cdc_db" + def mysqlTable = "test_streaming_job_cdc_stream_mysql_ds_src" + + sql """DROP JOB IF EXISTS where jobname = '${jobName}'""" + sql """drop table if exists ${currentDb}.${dorisTable} force""" + + sql """ + CREATE TABLE IF NOT EXISTS ${currentDb}.${dorisTable} ( + `name` varchar(200) NULL, + `age` int NULL + ) ENGINE=OLAP + UNIQUE KEY(`name`) + DISTRIBUTED BY HASH(`name`) BUCKETS AUTO + PROPERTIES ( + "replication_allocation" = "tag.location.default: 1", + "enable_unique_key_merge_on_write" = "true" + ) + """ + + String enabled = context.config.otherConfigs.get("enableJdbcTest") + if (enabled != null && enabled.equalsIgnoreCase("true")) { + String mysql_port = context.config.otherConfigs.get("mysql_57_port") + String externalEnvIp = context.config.otherConfigs.get("externalEnvIp") + String s3_endpoint = getS3Endpoint() + String bucket = getS3BucketName() + String driver_url = "https://${bucket}.${s3_endpoint}/regression/jdbc_driver/mysql-connector-j-8.4.0.jar"; + + // prepare source table with primary key and pre-existing snapshot data + connect("root", "123456", "jdbc:mysql://${externalEnvIp}:${mysql_port}") { + sql """CREATE DATABASE IF NOT EXISTS ${mysqlDb}""" + sql """DROP TABLE IF EXISTS ${mysqlDb}.${mysqlTable}""" + sql """CREATE TABLE ${mysqlDb}.${mysqlTable} ( + `name` varchar(200) NOT NULL, + `age` int DEFAULT NULL, + PRIMARY KEY (`name`) + ) ENGINE=InnoDB""" + sql """INSERT INTO ${mysqlDb}.${mysqlTable} (name, age) VALUES ('A1', 1)""" + sql """INSERT INTO ${mysqlDb}.${mysqlTable} (name, age) VALUES ('B1', 2)""" + } + + // create streaming job via cdc_stream TVF with delete sign enabled + sql """ + CREATE JOB ${jobName} + ON STREAMING DO INSERT INTO ${currentDb}.${dorisTable} (name, age, __DORIS_DELETE_SIGN__) + SELECT name, age, __DORIS_DELETE_SIGN__ FROM cdc_stream( + "type" = "mysql", + "jdbc_url" = "jdbc:mysql://${externalEnvIp}:${mysql_port}", + "driver_url" = "${driver_url}", + "driver_class" = "com.mysql.cj.jdbc.Driver", + "user" = "root", + "password" = "123456", + "database" = "${mysqlDb}", + "table" = "${mysqlTable}", + "offset" = "initial", + "snapshot_split_key" = "name", + "include_delete_sign" = "true" + ) + """ + + // wait for at least one snapshot task to succeed + try { + Awaitility.await().atMost(300, SECONDS).pollInterval(2, SECONDS).until({ + def cnt = sql """select SucceedTaskCount from jobs("type"="insert") where Name='${jobName}' and ExecuteType='STREAMING'""" + log.info("SucceedTaskCount: " + cnt) + cnt.size() == 1 && (cnt.get(0).get(0) as int) >= 1 + }) + } catch (Exception ex) { + log.info("job: " + (sql """select * from jobs("type"="insert") where Name='${jobName}'""")) + log.info("tasks: " + (sql """select * from tasks("type"="insert") where JobName='${jobName}'""")) + throw ex + } + + // verify snapshot data + qt_snapshot_data """ SELECT name, age FROM ${currentDb}.${dorisTable} ORDER BY name """ Review Comment: This new suite introduces several `qt_*` result checks, but the PR file list does not add the matching expected output file under `regression-test/data/job_p0/streaming_job/cdc/tvf/` (and the new PostgreSQL delete-sign suite has the same gap). When these external suites run with JDBC tests enabled, the regression framework will try to compare `qt_snapshot_data`, `qt_incremental_data`, `qt_after_update`, and `qt_after_delete` against generated expected output; with no `.out` file checked in, the tests fail before validating the CDC delete-sign behavior. Please generate and commit the `.out` files for both new suites. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
