github-actions[bot] commented on code in PR #65035:
URL: https://github.com/apache/doris/pull/65035#discussion_r3502797090
##########
fe/fe-core/src/main/java/org/apache/doris/datasource/doris/RemoteDorisExternalCatalog.java:
##########
@@ -188,7 +189,7 @@ protected void initLocalObjectsImpl() {
+ " please check your Doris cluster or your Doris catalog
configuration.");
}
client = new FeServiceClient(name, getFeThriftNodes(), getUsername(),
getPassword(),
- getMetadataSyncRetryCount(), getMetadataReadTimeoutSec());
Review Comment:
`FeServiceClient` already converts this constructor argument from seconds to
milliseconds (`timeoutS` -> `TimeUnit.SECONDS.toMillis(timeoutS)`) before
passing it to `ClientPool.frontendPool.borrowObject`, whose timeout is then
applied to `TSocket.setTimeout` in milliseconds. Converting at this call site
means the default `metadata_read_timeout_sec=10` becomes 10,000,000 ms (about
2.8 hours), so remote metadata/thrift operations can hang far longer than
configured. Please keep passing the seconds value here and, if needed, make the
unit boundary explicit inside `FeServiceClient` instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
