Gabriel39 opened a new pull request, #65054:
URL: https://github.com/apache/doris/pull/65054
### What problem does this PR solve?
Issue Number: None
Related PR: None
Problem Summary: Task-executor scan scheduling could pass a null or invalid
task handle into TimeSharingTaskExecutor. enqueue_splits and related paths cast
the base TaskHandle to TimeSharingTaskHandle and immediately dereferenced the
result, so a broken ScannerContext task-handle invariant caused BE to crash
with SIGSEGV instead of returning a diagnostic error. This change validates
scanner context, scan task, and task handle before submitting scan splits, and
validates the task handle type at TimeSharingTaskExecutor entry points before
dereferencing it.
### Release note
None
### Check List (For Author)
- Test: Unit Test
- Added TimeSharingTaskExecutorTest coverage for null and invalid task
handles.
- Tried:
JDK_17=/usr/local/opt/openjdk@17/libexec/openjdk.jdk/Contents/Home
JAVA_HOME=/usr/local/opt/openjdk@17/libexec/openjdk.jdk/Contents/Home
./run-be-ut.sh --run --filter='TimeSharingTaskExecutorTest.*'; build failed
during CMake configure because thirdparty/installed is missing Snappy.
- Behavior changed: Yes. Invalid task-executor scan handles now return
InternalError instead of dereferencing a null cast result.
- Does this need documentation: No
### What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should
merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
