github-actions[bot] commented on code in PR #64770:
URL: https://github.com/apache/doris/pull/64770#discussion_r3473025511
##########
be/src/io/cache/block_file_cache.cpp:
##########
@@ -817,15 +830,15 @@ std::string BlockFileCache::clear_file_cache_async() {
FileBlockSPtr file_block = cell->file_block;
if (file_block) {
std::lock_guard block_lock(file_block->_mutex);
Review Comment:
The sync clear path still reports success if the synchronous storage
deletion fails. `remove(..., sync_remove=true)` only logs a failed
`_storage->remove(key)` and then continues to subtract the block size and erase
the `_files` entry, so `clear_file_cache_sync()` returns a normal `finish`
message and the HTTP handler wraps it as `{"status":"OK"}`. That leaves the
cache file on disk while dropping the metadata that would let a later clear
retry it. Please propagate sync remove failures back through
`clear_file_cache_sync()`/`FileCacheFactory::clear_file_caches`, or keep the
metadata/retry path until the file has actually been removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
