github-actions[bot] commented on code in PR #64786:
URL: https://github.com/apache/doris/pull/64786#discussion_r3471554423
##########
fe/fe-core/src/main/java/org/apache/doris/load/routineload/kafka/KafkaRoutineLoadJob.java:
##########
@@ -723,7 +725,24 @@ public String dataSourcePropertiesJsonToString() {
@Override
public String customPropertiesJsonToString() {
Gson gson = new GsonBuilder().disableHtmlEscaping().create();
- return gson.toJson(customProperties);
+ return gson.toJson(getMaskedCustomProperties(""));
+ }
+
+ private Map<String, String> getMaskedCustomProperties(String keyPrefix) {
+ Map<String, String> maskedProperties = new HashMap<>();
+ customProperties.forEach((key, value) -> {
Review Comment:
This still leaves supported Kafka OAuth/OIDC secrets visible. Doris accepts
any `property.*` key in `KafkaDataSourceProperties.analyzeCustomProperties`,
strips the prefix, then forwards the resulting map to BE/librdkafka, so a
routine load can legitimately use `property.sasl.oauthbearer.client.secret` or
the `sasl.oauthbearer.client.credentials.client.secret` alias. Those keys do
not match any branch in this predicate because they end in `.secret`, not
`.secret_key` or `.secret.key`, so `SHOW ROUTINE LOAD`,
`information_schema.routine_load_jobs`, and `SHOW CREATE ROUTINE LOAD` still
serialize the raw secret. Please broaden this sensitive-key test to cover the
Kafka OAuth secret/private-key/passphrase forms and add a unit case for
`sasl.oauthbearer.client.secret`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
