0AyanamiRei opened a new pull request, #64786:
URL: https://github.com/apache/doris/pull/64786
### What problem does this PR solve?
Issue Number: None
Related PR: None
Problem Summary: Kafka routine load custom properties were rendered directly
in SHOW ROUTINE LOAD, SHOW CREATE ROUTINE LOAD, and
information_schema.routine_load_jobs, so SASL, SSL, and AWS credential values
could be exposed through job metadata. This change masks sensitive Kafka custom
property values when formatting external display output while preserving the
internal properties used by Kafka clients. Added unit and regression coverage
for masked display output and unchanged internal values.
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [x] Regression test
- [x] Unit Test
- [x] Manual test (add detailed scripts or steps below)
- ./build.sh --fe -j60
- ./run-fe-ut.sh --run
org.apache.doris.load.routineload.KafkaRoutineLoadJobTest#testDisplayCustomPropertiesMasksKafkaSecrets
- ./run-regression-test.sh --run -d load_p0/routine_load -s
test_show_routine_load -c
'jdbc:mysql://127.0.0.1:62030/?useLocalSessionState=true&allowLoadLocalInfile=true&zeroDateTimeBehavior=round'
-ha 127.0.0.1:61030 -conf enableKafkaTest=true -conf kafka_port=19194 -conf
externalEnvIp=127.0.0.1
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [x] Yes. <!-- Sensitive Kafka routine load custom properties are
masked in display output. -->
- Does this need documentation?
- [x] No.
- [ ] Yes. <!-- Add document PR link here. eg:
https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should
merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
