github-actions[bot] commented on code in PR #64718:
URL: https://github.com/apache/doris/pull/64718#discussion_r3465672334


##########
regression-test/data/query_p0/keyword/test_keyword.out:
##########
@@ -29,7 +29,7 @@ TRUE
 -- !distinct9 --
 0.1
 20.268
-78945.0
+78945

Review Comment:
   This expected-output update includes numeric-format churn that is unrelated 
to the USING join fix. The suite file is unchanged, and the PR only changes 
planner/USING join code, but this file now expects results like `78945` instead 
of `78945.0`, `2` instead of `2.0`, and rounded `3.141593` instead of 
`3.1415927` in non-USING sections such as `distinct9`, `distinct17`, 
`distinct25`, and the cross-product output. Those rows are not produced by the 
changed USING alias cases (`alias15`, `alias20`, `alias21`), so the generated 
expected file no longer matches the current behavior this PR is changing and 
can break unrelated regression checks. Please regenerate/revert this file and 
keep only the USING-join result changes.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to