github-actions[bot] commented on code in PR #64561:
URL: https://github.com/apache/doris/pull/64561#discussion_r3465306840
##########
fe/fe-core/src/main/java/org/apache/doris/encryption/RootKeyInfo.java:
##########
@@ -24,7 +24,9 @@
public class RootKeyInfo {
public enum RootKeyType {
LOCAL("local"),
- AWS_KMS("aws_kms");
+ AWS_KMS("aws_kms"),
+ ALIYUN_KMS("aliyun_kms"),
Review Comment:
Adding `ALIYUN_KMS` makes the existing admin-command parser
locale-sensitive. `AdminSetEncryptionRootKeyCommand.validate()` still does
`RootKeyInfo.RootKeyType.valueOf(typeValue.toUpperCase())`; on a JVM running
with Turkish default locale, `"aliyun_kms".toUpperCase()` becomes `ALİYUN_KMS`,
so the documented provider value is rejected as `invalid root key type`. Since
this enum now has `tryFrom()` using `equalsIgnoreCase`, please route the
command through that helper (or at least use `toUpperCase(Locale.ROOT)`) before
accepting the new provider.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
