Copilot commented on code in PR #64775:
URL: https://github.com/apache/doris/pull/64775#discussion_r3465273765
##########
be/test/CMakeLists.txt:
##########
@@ -23,6 +23,12 @@ set(EXECUTABLE_OUTPUT_PATH "${BUILD_DIR}/test")
file(GLOB_RECURSE UT_FILES CONFIGURE_DEPENDS *.cpp)
+if (ENABLE_VARIANT_NESTED_GROUP)
+ file(GLOB_RECURSE VARIANT_NESTED_GROUP_UT_FILES CONFIGURE_DEPENDS
+
"${CMAKE_CURRENT_SOURCE_DIR}/${VARIANT_NESTED_GROUP_MODULE_DIR}/*.cpp")
+ list(APPEND UT_FILES ${VARIANT_NESTED_GROUP_UT_FILES})
+endif()
Review Comment:
`UT_FILES` is already populated via `file(GLOB_RECURSE UT_FILES ... *.cpp)`
from `${CMAKE_CURRENT_SOURCE_DIR}`, so globs rooted at
`${CMAKE_CURRENT_SOURCE_DIR}/${VARIANT_NESTED_GROUP_MODULE_DIR}` cannot add any
new files unless `VARIANT_NESTED_GROUP_MODULE_DIR` escapes the test dir (e.g.,
via `../`). This makes the block either redundant (and potentially introduces
duplicate source entries) or ineffective for the stated goal of bringing in
external module UT sources.
##########
be/CMakeLists.txt:
##########
@@ -148,6 +148,12 @@ message(STATUS "build file cache lru tool:
${BUILD_FILE_CACHE_LRU_TOOL}")
option(ENABLE_PAIMON_CPP "Enable Paimon C++ integration" ON)
set(PAIMON_HOME "" CACHE PATH "Paimon install prefix")
+option(ENABLE_VARIANT_NESTED_GROUP "Enable Variant NestedGroup feature module"
OFF)
+set(VARIANT_NESTED_GROUP_MODULE_DIR "" CACHE STRING "Variant NestedGroup
feature module directory under be/src")
Review Comment:
The cache help text says `VARIANT_NESTED_GROUP_MODULE_DIR` is a directory
under `be/src`, but it’s also used in `be/test/CMakeLists.txt` as a path under
`be/test`. This is confusing for users configuring the option; please clarify
the description to match how the variable is interpreted by the build.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
