github-actions[bot] commented on code in PR #64669:
URL: https://github.com/apache/doris/pull/64669#discussion_r3450941926
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/functions/agg/Sum0.java:
##########
@@ -53,7 +53,7 @@
/**
* AggregateFunction 'sum0'. sum0 returns the sum of the values which go into
it like sum.
- * It differs in that when no non null values are applied zero is returned
instead of null.
+ * when all input values are null, it returns zero instead of null.
Review Comment:
The new wording no longer covers empty aggregate input. `Sum0` still
implements `resultForEmptyInput()` as zero, and existing regression output for
`select sum0(kint)` over an empty table expects `0`, so the distinguishing
behavior is "no non-null values" rather than only "all input values are null".
```suggestion
* When the aggregate input is empty or all input values are null, it
returns zero instead of null.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
