hoshinojyunn commented on code in PR #64652:
URL: https://github.com/apache/doris/pull/64652#discussion_r3449692339
##########
be/src/storage/tablet/tablet_meta.cpp:
##########
@@ -543,6 +543,7 @@ void TabletMeta::init_schema_from_thrift(const
TTabletSchema& tablet_schema,
DCHECK_EQ(index.columns.size(), 1);
if (iequal(tcolumn.column_name, index.columns[0])) {
column->set_is_bf_column(true);
+ has_bf_columns = true;
Review Comment:
`has_bf_columns` is used to set the bloom filter function (FPP) in the
following text. In the current design, the FPP of the named BF index depends on
the `bloom_filter_fpp` defined in the table properties. Therefore, when
checking the indexes of `tablet_meta`, if an index of type `BLOOMFILTER`
exists, `has_bf_columns` is set to `true` so that `bloom_filter_fpp` can be set
correctly in the following text (a better approach would be to handle
`NGRAM_BF` and `BLOOMFILTER` separately).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
