github-actions[bot] commented on code in PR #64639:
URL: https://github.com/apache/doris/pull/64639#discussion_r3435159113
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/analysis/SubqueryToApply.java:
##########
@@ -656,7 +656,9 @@ SELECT SUM(a)
MarkJoinSlotReference markJoinSlotReference =
new
MarkJoinSlotReference(statementContext.generateColumnName());
context.setSubqueryToMarkJoinSlot(exists,
Optional.of(markJoinSlotReference));
- return new Nvl(markJoinSlotReference,
BooleanLiteral.FALSE);
+ // for general mark semi/anti join, execution engine will
not produce NULL,
+ // so use mark slot directly.
+ return markJoinSlotReference;
Review Comment:
This changes the expression used for every `EXISTS`/`NOT EXISTS` mark slot,
including filter/project/join subquery rewrites. Please add a targeted
regression case for the reported correlated `NOT EXISTS` wrong-filter shape,
with ordered output and generated `.out` results. The existing suites have
related subquery cases, but this PR has no test/result update that proves the
old `nvl(mark, false)` path fails and this raw mark-slot form is correct.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
