seawinde opened a new pull request, #64636:
URL: https://github.com/apache/doris/pull/64636

   ### What problem does this PR solve?
   
   Issue Number: N/A
   
   Related PR: N/A
   
   Problem Summary:
   `OptimizeGetAvailableMvsTest` could fail intermittently because 
`TestWithFeService` reuses the same FE environment across test methods. If a 
materialized view survived a failed assertion, a later case could see an extra 
rewrite candidate. The partition-prune case also depended on asynchronous MTMV 
refresh state before the materialized view became a rewrite candidate, so the 
candidate map could be empty.
   
   Root cause: In `OptimizeGetAvailableMvsTest`, test methods created 
materialized views with fixed names and only dropped them at the end of the 
happy path, so failed assertions could leave state behind for later test 
methods. The partition-prune case also did not mock `MTMV.canBeCandidate()`, 
which made the test depend on asynchronous MTMV refresh state.
   
   Change Summary:
   
   | File | Change Description |
   |------|--------------------|
   | `OptimizeGetAvailableMvsTest.java` | Drop test materialized views before 
and after each test. |
   | `OptimizeGetAvailableMvsTest.java` | Mock `MTMV.canBeCandidate()` in the 
partition-prune case. |
   
   ### Release note
   
   None
   
   ### Check List (For Author)
   
   - Test
       - [ ] Regression test
       - [x] Unit Test
       - [ ] Manual test (add detailed scripts or steps below)
       - [ ] No need to test or manual test. Explain why:
           - [ ] This is a refactor/code format and no logic has been changed.
           - [ ] Previous test can cover this change.
           - [ ] No code files have been changed.
           - [ ] Other reason
   
   - Behavior changed:
       - [x] No.
       - [ ] Yes.
   
   - Does this need documentation?
       - [x] No.
       - [ ] Yes.
   
   ### Check List (For Reviewer who merge this PR)
   
   - [ ] Confirm the release note
   - [ ] Confirm test cases
   - [ ] Confirm document
   - [ ] Add branch pick label
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to