JNSimba commented on code in PR #64423:
URL: https://github.com/apache/doris/pull/64423#discussion_r3432630108
##########
fs_brokers/cdc_client/src/main/java/org/apache/doris/cdcclient/controller/ClientController.java:
##########
@@ -129,12 +130,25 @@ public Object compareOffset(@RequestBody
CompareOffsetRequest compareOffsetReque
/** Close job */
@RequestMapping(path = "/api/close", method = RequestMethod.POST)
public Object close(@RequestBody JobBaseConfig jobConfig) {
- LOG.info("Closing job {}", jobConfig.getJobId());
+ String jobId = jobConfig.getJobId();
+ LOG.info("Closing job {}", jobId);
Env env = Env.getCurrentEnv();
- SourceReader reader = env.getReader(jobConfig);
- reader.close(jobConfig);
- env.close(jobConfig.getJobId());
- pipelineCoordinator.closeJobStreamLoad(jobConfig.getJobId());
+ // Don't rebuild a reader to close it; an absent reader (owner BE
gone) just needs its slot
+ // dropped.
+ SourceReader reader = env.getReaderIfPresent(jobId);
+ try {
+ if (reader != null) {
+ reader.release(jobConfig);
+ }
+ SourceReader dropper = reader != null ? reader :
env.getMetaReader(jobConfig);
+ env.releaseSourceResourcesOrRetry(dropper, jobConfig);
+ } catch (Exception ex) {
+ LOG.warn("Close job {} teardown failed: {}", jobId,
ex.getMessage());
+ env.scheduleSlotDrop(jobConfig);
+ } finally {
+ env.close(jobId);
Review Comment:
The exception from `close` has been caught by the upstream.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
