github-actions[bot] commented on code in PR #63366:
URL: https://github.com/apache/doris/pull/63366#discussion_r3399953617
##########
gensrc/thrift/Partitions.thrift:
##########
@@ -119,3 +153,5 @@ struct TDataPartition {
3: optional list<TRangePartition> partition_infos
4: optional TMergePartitionInfo merge_partition_info
}
+
Review Comment:
`git diff --check` reports `gensrc/thrift/Partitions.thrift:156: new blank
line at EOF` after this closing brace. Please remove the extra trailing blank
line(s) so the file ends here.
##########
regression-test/data/query_p0/join/test_multilevel_join_agg_local_shuffle.out:
##########
@@ -0,0 +1,815 @@
+-- This file is automatically generated. You should know what you did if you
want to edit this
+-- !bucket_shuffle_broadcast_agg_stage_1_result_on --
+1 52 11 10
+2 9 7 20
+3 8 8 30
+4 10 9 40
+
+-- !bucket_shuffle_broadcast_agg_stage_1_result_off --
+1 52 11 10
+2 9 7 20
+3 8 8 30
+4 10 9 40
+
+-- !bucket_shuffle_broadcast_agg_stage_2_result_on --
+1 52 11 10
+2 9 7 20
+3 8 8 30
+4 10 9 40
+
+-- !bucket_shuffle_broadcast_agg_stage_2_result_off --
+1 52 11 10
+2 9 7 20
+3 8 8 30
+4 10 9 40
+
+-- !bucket_shuffle_broadcast_agg_stage_3_result_on --
+1 52 11 10
+2 9 7 20
+3 8 8 30
+4 10 9 40
+
+-- !bucket_shuffle_broadcast_agg_stage_3_result_off --
+1 52 11 10
+2 9 7 20
+3 8 8 30
+4 10 9 40
+
+-- !shuffle_broadcast_broadcast_agg_stage_1_result_on --
+1 10 62 10
+2 5 54 20
+3 5 38 30
+4 6 49 40
+
+-- !shuffle_broadcast_broadcast_agg_stage_1_result_off --
+1 10 62 10
+2 5 54 20
+3 5 38 30
+4 6 49 40
+
+-- !shuffle_broadcast_broadcast_agg_stage_2_result_on --
+1 10 62 10
+2 5 54 20
+3 5 38 30
+4 6 49 40
+
+-- !shuffle_broadcast_broadcast_agg_stage_2_result_off --
+1 10 62 10
+2 5 54 20
+3 5 38 30
+4 6 49 40
+
+-- !shuffle_broadcast_broadcast_agg_stage_3_result_on --
+1 10 62 10
+2 5 54 20
+3 5 38 30
+4 6 49 40
+
+-- !shuffle_broadcast_broadcast_agg_stage_3_result_off --
+1 10 62 10
+2 5 54 20
+3 5 38 30
+4 6 49 40
+
+-- !bucket_broadcast_shuffle_agg_stage_1_result_on --
+1 26 11 10
+2 9 7 20
+3 8 8 30
+4 10 9 40
+
+-- !bucket_broadcast_shuffle_agg_stage_1_result_off --
+1 26 11 10
+2 9 7 20
+3 8 8 30
+4 10 9 40
+
+-- !bucket_broadcast_shuffle_agg_stage_2_result_on --
+1 26 11 10
+2 9 7 20
+3 8 8 30
+4 10 9 40
+
+-- !bucket_broadcast_shuffle_agg_stage_2_result_off --
+1 26 11 10
+2 9 7 20
+3 8 8 30
+4 10 9 40
+
+-- !bucket_broadcast_shuffle_agg_stage_3_result_on --
+1 26 11 10
+2 9 7 20
+3 8 8 30
+4 10 9 40
+
+-- !bucket_broadcast_shuffle_agg_stage_3_result_off --
+1 26 11 10
+2 9 7 20
+3 8 8 30
+4 10 9 40
+
+-- !alternating_bucket_bucket_bucket_result_on --
+1 63 16 11
+2 16 24 22
+3 16 35 33
+4 19 46 44
+
+-- !alternating_bucket_bucket_bucket_result_off --
+1 63 16 11
+2 16 24 22
+3 16 35 33
+4 19 46 44
+
+-- !alternating_bucket_bucket_shuffle_result_on --
+1 63 16 11
+2 16 24 22
+3 16 35 33
+4 19 46 44
+
+-- !alternating_bucket_bucket_shuffle_result_off --
+1 63 16 11
+2 16 24 22
+3 16 35 33
+4 19 46 44
+
+-- !alternating_bucket_bucket_broadcast_result_on --
+1 63 16 11
+2 16 24 22
+3 16 35 33
+4 19 46 44
+
+-- !alternating_bucket_bucket_broadcast_result_off --
+1 63 16 11
+2 16 24 22
+3 16 35 33
+4 19 46 44
+
+-- !alternating_bucket_shuffle_bucket_result_on --
+1 63 16 11
+2 16 24 22
+3 16 35 33
+4 19 46 44
+
+-- !alternating_bucket_shuffle_bucket_result_off --
+1 63 16 11
+2 16 24 22
+3 16 35 33
+4 19 46 44
+
+-- !alternating_bucket_shuffle_shuffle_result_on --
+1 63 16 11
+2 16 24 22
+3 16 35 33
+4 19 46 44
+
+-- !alternating_bucket_shuffle_shuffle_result_off --
+1 63 16 11
+2 16 24 22
+3 16 35 33
+4 19 46 44
+
+-- !alternating_bucket_shuffle_broadcast_result_on --
+1 63 16 11
+2 16 24 22
+3 16 35 33
+4 19 46 44
+
+-- !alternating_bucket_shuffle_broadcast_result_off --
+1 63 16 11
+2 16 24 22
+3 16 35 33
+4 19 46 44
+
+-- !alternating_bucket_broadcast_bucket_result_on --
+1 63 16 11
+2 16 24 22
+3 16 35 33
+4 19 46 44
+
+-- !alternating_bucket_broadcast_bucket_result_off --
+1 63 16 11
+2 16 24 22
+3 16 35 33
+4 19 46 44
+
+-- !alternating_bucket_broadcast_shuffle_result_on --
+1 63 16 11
+2 16 24 22
+3 16 35 33
+4 19 46 44
+
+-- !alternating_bucket_broadcast_shuffle_result_off --
+1 63 16 11
+2 16 24 22
+3 16 35 33
+4 19 46 44
+
+-- !alternating_bucket_broadcast_broadcast_result_on --
+1 63 16 11
+2 16 24 22
+3 16 35 33
+4 19 46 44
+
+-- !alternating_bucket_broadcast_broadcast_result_off --
+1 63 16 11
+2 16 24 22
+3 16 35 33
+4 19 46 44
+
+-- !alternating_shuffle_bucket_bucket_result_on --
+1 63 16 11
+2 16 24 22
+3 16 35 33
+4 19 46 44
+
+-- !alternating_shuffle_bucket_bucket_result_off --
+1 63 16 11
+2 16 24 22
+3 16 35 33
+4 19 46 44
+
+-- !alternating_shuffle_bucket_shuffle_result_on --
+1 63 16 11
+2 16 24 22
+3 16 35 33
+4 19 46 44
+
+-- !alternating_shuffle_bucket_shuffle_result_off --
+1 63 16 11
+2 16 24 22
+3 16 35 33
+4 19 46 44
+
+-- !alternating_shuffle_bucket_broadcast_result_on --
+1 63 16 11
+2 16 24 22
+3 16 35 33
+4 19 46 44
+
+-- !alternating_shuffle_bucket_broadcast_result_off --
+1 63 16 11
+2 16 24 22
+3 16 35 33
+4 19 46 44
+
+-- !alternating_shuffle_shuffle_bucket_result_on --
+1 63 16 11
+2 16 24 22
+3 16 35 33
+4 19 46 44
+
+-- !alternating_shuffle_shuffle_bucket_result_off --
+1 63 16 11
+2 16 24 22
+3 16 35 33
+4 19 46 44
+
+-- !alternating_shuffle_shuffle_shuffle_result_on --
+1 63 16 11
+2 16 24 22
+3 16 35 33
+4 19 46 44
+
+-- !alternating_shuffle_shuffle_shuffle_result_off --
+1 63 16 11
+2 16 24 22
+3 16 35 33
+4 19 46 44
+
+-- !alternating_shuffle_shuffle_broadcast_result_on --
+1 63 16 11
+2 16 24 22
+3 16 35 33
+4 19 46 44
+
+-- !alternating_shuffle_shuffle_broadcast_result_off --
+1 63 16 11
+2 16 24 22
+3 16 35 33
+4 19 46 44
+
+-- !alternating_shuffle_broadcast_bucket_result_on --
+1 63 16 11
+2 16 24 22
+3 16 35 33
+4 19 46 44
+
+-- !alternating_shuffle_broadcast_bucket_result_off --
+1 63 16 11
+2 16 24 22
+3 16 35 33
+4 19 46 44
+
+-- !alternating_shuffle_broadcast_shuffle_result_on --
+1 63 16 11
+2 16 24 22
+3 16 35 33
+4 19 46 44
+
+-- !alternating_shuffle_broadcast_shuffle_result_off --
+1 63 16 11
+2 16 24 22
+3 16 35 33
+4 19 46 44
+
+-- !alternating_shuffle_broadcast_broadcast_result_on --
+1 63 16 11
+2 16 24 22
+3 16 35 33
+4 19 46 44
+
+-- !alternating_shuffle_broadcast_broadcast_result_off --
+1 63 16 11
+2 16 24 22
+3 16 35 33
+4 19 46 44
+
+-- !alternating_broadcast_bucket_bucket_result_on --
+1 63 16 11
+2 16 24 22
+3 16 35 33
+4 19 46 44
+
+-- !alternating_broadcast_bucket_bucket_result_off --
+1 63 16 11
+2 16 24 22
+3 16 35 33
+4 19 46 44
+
+-- !alternating_broadcast_bucket_shuffle_result_on --
+1 63 16 11
+2 16 24 22
+3 16 35 33
+4 19 46 44
+
+-- !alternating_broadcast_bucket_shuffle_result_off --
+1 63 16 11
+2 16 24 22
+3 16 35 33
+4 19 46 44
+
+-- !alternating_broadcast_bucket_broadcast_result_on --
+1 63 16 11
+2 16 24 22
+3 16 35 33
+4 19 46 44
+
+-- !alternating_broadcast_bucket_broadcast_result_off --
+1 63 16 11
+2 16 24 22
+3 16 35 33
+4 19 46 44
+
+-- !alternating_broadcast_shuffle_bucket_result_on --
+1 63 16 11
+2 16 24 22
+3 16 35 33
+4 19 46 44
+
+-- !alternating_broadcast_shuffle_bucket_result_off --
+1 63 16 11
+2 16 24 22
+3 16 35 33
+4 19 46 44
+
+-- !alternating_broadcast_shuffle_shuffle_result_on --
+1 63 16 11
+2 16 24 22
+3 16 35 33
+4 19 46 44
+
+-- !alternating_broadcast_shuffle_shuffle_result_off --
+1 63 16 11
+2 16 24 22
+3 16 35 33
+4 19 46 44
+
+-- !alternating_broadcast_shuffle_broadcast_result_on --
+1 63 16 11
+2 16 24 22
+3 16 35 33
+4 19 46 44
+
+-- !alternating_broadcast_shuffle_broadcast_result_off --
+1 63 16 11
+2 16 24 22
+3 16 35 33
+4 19 46 44
+
+-- !alternating_broadcast_broadcast_bucket_result_on --
+1 63 16 11
+2 16 24 22
+3 16 35 33
+4 19 46 44
+
+-- !alternating_broadcast_broadcast_bucket_result_off --
+1 63 16 11
+2 16 24 22
+3 16 35 33
+4 19 46 44
+
+-- !alternating_broadcast_broadcast_shuffle_result_on --
+1 63 16 11
+2 16 24 22
+3 16 35 33
+4 19 46 44
+
+-- !alternating_broadcast_broadcast_shuffle_result_off --
+1 63 16 11
+2 16 24 22
+3 16 35 33
+4 19 46 44
+
+-- !alternating_broadcast_broadcast_broadcast_result_on --
+1 63 16 11
+2 16 24 22
+3 16 35 33
+4 19 46 44
+
+-- !alternating_broadcast_broadcast_broadcast_result_off --
+1 63 16 11
+2 16 24 22
+3 16 35 33
+4 19 46 44
+
+-- !window_union_all_bucket_row_number_result_on --
+1 52 4 40
+2 21 3 60
+3 16 2 60
+4 20 2 80
+
+-- !window_union_all_bucket_row_number_result_off --
+1 52 4 40
+2 21 3 60
+3 16 2 60
+4 20 2 80
+
+-- !window_union_all_bucket_window_sum_result_on --
+1 10 13 40
+2 6 7 60
+3 3 8 60
+4 3 10 80
+
+-- !window_union_all_bucket_window_sum_result_off --
+1 10 13 40
+2 6 7 60
+3 3 8 60
+4 3 10 80
+
+-- !window_union_all_shuffle_row_number_result_on --
+1 208 8 44
+2 21 3 21
+3 16 2 16
+4 20 2 18
+
+-- !window_union_all_shuffle_row_number_result_off --
+1 208 8 44
+2 21 3 21
+3 16 2 16
+4 20 2 18
+
+-- !window_union_all_shuffle_window_sum_result_on --
+1 36 26 44
+2 6 7 21
+3 3 8 16
+4 3 10 18
+
+-- !window_union_all_shuffle_window_sum_result_off --
+1 36 26 44
+2 6 7 21
+3 3 8 16
+4 3 10 18
+
+-- !window_union_all_broadcast_row_number_result_on --
+1 52 4 40
+2 21 3 60
+3 16 2 60
+4 20 2 80
+
+-- !window_union_all_broadcast_row_number_result_off --
+1 52 4 40
+2 21 3 60
+3 16 2 60
+4 20 2 80
+
+-- !window_union_all_broadcast_window_sum_result_on --
+1 10 13 40
+2 6 7 60
+3 3 8 60
+4 3 10 80
+
+-- !window_union_all_broadcast_window_sum_result_off --
+1 10 13 40
+2 6 7 60
+3 3 8 60
+4 3 10 80
+
+-- !window_except_bucket_row_number_result_on --
+1 10 2 20
+2 10 2 40
+3 5 1 30
+4 6 1 40
+
+-- !window_except_bucket_row_number_result_off --
+1 10 2 20
+2 10 2 40
+3 5 1 30
+4 6 1 40
+
+-- !window_except_bucket_window_sum_result_on --
+1 3 5 20
+2 3 5 40
+3 1 5 30
+4 1 6 40
+
+-- !window_except_bucket_window_sum_result_off --
+1 3 5 20
+2 3 5 40
+3 1 5 30
+4 1 6 40
+
+-- !window_except_shuffle_row_number_result_on --
+1 40 4 22
+2 10 2 14
+3 5 1 8
+4 6 1 9
+
+-- !window_except_shuffle_row_number_result_off --
+1 40 4 22
+2 10 2 14
+3 5 1 8
+4 6 1 9
+
+-- !window_except_shuffle_window_sum_result_on --
+1 10 10 22
+2 3 5 14
+3 1 5 8
+4 1 6 9
+
+-- !window_except_shuffle_window_sum_result_off --
+1 10 10 22
+2 3 5 14
+3 1 5 8
+4 1 6 9
+
+-- !window_except_broadcast_row_number_result_on --
+1 10 2 20
+2 10 2 40
+3 5 1 30
+4 6 1 40
+
+-- !window_except_broadcast_row_number_result_off --
+1 10 2 20
+2 10 2 40
+3 5 1 30
+4 6 1 40
+
+-- !window_except_broadcast_window_sum_result_on --
+1 3 5 20
+2 3 5 40
+3 1 5 30
+4 1 6 40
+
+-- !window_except_broadcast_window_sum_result_off --
+1 3 5 20
+2 3 5 40
+3 1 5 30
+4 1 6 40
+
+-- !window_intersect_bucket_row_number_result_on --
+
+-- !window_intersect_bucket_row_number_result_off --
+
+-- !window_intersect_bucket_window_sum_result_on --
+
+-- !window_intersect_bucket_window_sum_result_off --
+
+-- !window_intersect_shuffle_row_number_result_on --
+
+-- !window_intersect_shuffle_row_number_result_off --
+
+-- !window_intersect_shuffle_window_sum_result_on --
+
+-- !window_intersect_shuffle_window_sum_result_off --
+
+-- !window_intersect_broadcast_row_number_result_on --
+
+-- !window_intersect_broadcast_row_number_result_off --
+
+-- !window_intersect_broadcast_window_sum_result_on --
+
+-- !window_intersect_broadcast_window_sum_result_off --
+
+-- !bucket_broadcast_agg_result_on --
+1 26 10
+2 9 20
+3 8 30
+4 10 40
+
+-- !bucket_broadcast_agg_result_off --
+1 26 10
+2 9 20
+3 8 30
+4 10 40
+
+-- !partitioned_broadcast_agg_result_on --
+1 32 10
+2 19 20
+3 13 30
+4 15 40
+
+-- !partitioned_broadcast_agg_result_off --
+1 32 10
+2 19 20
+3 13 30
+4 15 40
+
+-- !bucket_partitioned_agg_result_on --
+1 52 44
+2 9 14
+3 8 8
+4 10 9
+
+-- !bucket_partitioned_agg_result_off --
+1 52 44
+2 9 14
+3 8 8
+4 10 9
+
+-- !all_three_multilevel_agg_result_on --
+1 96 10
+2 23 20
+3 16 30
+4 19 40
+
+-- !all_three_multilevel_agg_result_off --
+1 96 10
+2 23 20
+3 16 30
+4 19 40
+
+-- !agg_join_agg_mix_result_on --
+1 10 11 10
+2 5 7 20
+3 5 8 30
+4 6 9 40
+
+-- !agg_join_agg_mix_result_off --
+1 10 11 10
+2 5 7 20
+3 5 8 30
+4 6 9 40
+
+-- !double_broadcast_after_bucket_result_on --
+1 26 20
+2 9 40
+3 8 60
+4 10 80
+
+-- !double_broadcast_after_bucket_result_off --
+1 26 20
+2 9 40
+3 8 60
+4 10 80
+
+-- !partitioned_join_between_two_aggs_then_broadcast_result_on --
+1 16 10
+2 12 20
+3 13 30
+4 15 40
+
+-- !partitioned_join_between_two_aggs_then_broadcast_result_off --
+1 16 10
+2 12 20
+3 13 30
+4 15 40
+
+-- !bucket_shuffle_broadcast_two_stage_agg_result_on --
+1 52 44 10
+2 9 14 20
+3 8 8 30
+4 10 9 40
+
+-- !bucket_shuffle_broadcast_two_stage_agg_result_off --
+1 52 44 10
+2 9 14 20
+3 8 8 30
+4 10 9 40
+
+-- !left_join_null_preserving_with_multilevel_agg_result_on --
+1 5 44
+2 5 14
+3 5 8
+4 6 9
+
+-- !left_join_null_preserving_with_multilevel_agg_result_off --
+1 5 44
+2 5 14
+3 5 8
+4 6 9
+
+-- !seven_layer_bucket_shuffle_broadcast_result_on --
+1 37 10
+2 16 20
+3 16 30
+4 19 40
+
+-- !seven_layer_bucket_shuffle_broadcast_result_off --
+1 37 10
+2 16 20
+3 16 30
+4 19 40
+
+-- !eight_layer_mixed_join_agg_chain_result_on --
+1 52 44 20
+2 9 14 40
+3 8 8 60
+4 10 9 80
+
+-- !eight_layer_mixed_join_agg_chain_result_off --
+1 52 44 20
+2 9 14 40
+3 8 8 60
+4 10 9 80
+
+-- !seven_layer_left_join_mix_result_on --
+1 10 11 10
+2 5 7 20
+3 5 8 30
+4 6 9 40
+
+-- !seven_layer_left_join_mix_result_off --
+1 10 11 10
+2 5 7 20
+3 5 8 30
+4 6 9 40
+
+-- !broadcast_shuffle_broadcast_nested_agg_result_on --
+1 26 11 10
+2 9 7 20
+3 8 8 30
+4 10 9 40
+
+-- !broadcast_shuffle_broadcast_nested_agg_result_off --
+1 26 11 10
+2 9 7 20
+3 8 8 30
+4 10 9 40
+
+-- !window_union_join_agg_result_on --
+1 13 14
+2 7 23
+3 8 32
+4 10 42
+
+-- !window_union_join_agg_result_off --
+1 13 14
+2 7 23
+3 8 32
+4 10 42
+
+-- !window_except_join_agg_result_on --
+1 1 10
+2 1 20
+3 1 30
+
+-- !window_except_join_agg_result_off --
+1 1 10
+2 1 20
+3 1 30
+
+-- !window_intersect_shuffle_agg_result_on --
+1 22 2
+2 7 1
+3 8 1
+4 9 1
+
+-- !window_intersect_shuffle_agg_result_off --
+1 22 2
+2 7 1
+3 8 1
+4 9 1
+
+-- !window_union_except_broadcast_agg_result_on --
+1 13 4 10
+2 7 3 20
+3 8 2 30
+4 10 2 40
+
+-- !window_union_except_broadcast_agg_result_off --
+1 13 4 10
+2 7 3 20
+3 8 2 30
+4 10 2 40
+
+-- !window_setop_join_agg_chain_result_on --
+1 20 2 22
+2 10 2 14
+3 5 1 8
+4 6 1 9
+
+-- !window_setop_join_agg_chain_result_off --
+1 20 2 22
+2 10 2 14
+3 5 1 8
+4 6 1 9
+
Review Comment:
`git diff --check` reports
`regression-test/data/query_p0/join/test_multilevel_join_agg_local_shuffle.out:815:
new blank line at EOF` after this result row. Please regenerate or trim the
expected output so it ends here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
