HappenLee commented on code in PR #63389: URL: https://github.com/apache/doris/pull/63389#discussion_r3394238296
########## be/src/storage/index/zone_map/zonemap_eval_context.h: ########## @@ -0,0 +1,77 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#pragma once + +#include <parallel_hashmap/phmap.h> + +#include <optional> + +#include "core/data_type/data_type.h" +#include "storage/index/zone_map/zone_map_index.h" +#include "storage/index/zone_map/zonemap_filter_result.h" + +namespace doris { + +class RuntimeProfile; + +class ZoneMapEvalStats { +public: + void merge_page_eval_stats(const ZoneMapEvalStats& src); + void accumulate_into_profile(RuntimeProfile* profile) const; + + template <typename ReaderStatistics> + void accumulate_to(ReaderStatistics* stats) const { + if (stats == nullptr) { + return; + } + stats->expr_zonemap_unsupported_exprs += unsupported_expr_count; + stats->in_zonemap_point_check_count += in_zonemap_point_check_count; + stats->in_zonemap_range_only_count += in_zonemap_range_only_count; + } + + int64_t unsupported_expr_count = 0; + int64_t in_zonemap_point_check_count = 0; + int64_t in_zonemap_range_only_count = 0; +}; + +class ZoneMapEvalContext { +public: + struct SlotZoneMap { + DataTypePtr data_type; + std::optional<segment_v2::ZoneMap> zone_map; + }; + + const segment_v2::ZoneMap* zone_map(int slot_index) const; + const DataTypePtr* data_type(int slot_index) const; + void accumulate_into_profile(RuntimeProfile* profile) const; + + phmap::flat_hash_map<int, SlotZoneMap> slots; + + mutable ZoneMapEvalStats stats; +}; + +inline void record_unsupported_zonemap_filter(const ZoneMapEvalContext& ctx) { + ++ctx.stats.unsupported_expr_count; Review Comment: unsupported_expr_count 这个指导底统计的是什么东西啊？你这不应该是失效的这个zonemap数目吗?为什么搞一个这个名字还要额外搞个函数，拢共就一个加法 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
