yiguolei commented on code in PR #64128:
URL: https://github.com/apache/doris/pull/64128#discussion_r3377896148
##########
be/src/core/column/column_decimal.h:
##########
@@ -148,6 +148,20 @@ class ColumnDecimal final : public COWHelper<IColumn,
ColumnDecimal<T>> {
memset(data.data() + old_size, 0, length * sizeof(data[0]));
}
+ Status filter_by_selector(const uint16_t* sel, size_t sel_size, IColumn*
col_ptr) override {
+ Self* output = assert_cast<Self*>(col_ptr);
+ auto& res_data = output->get_data();
+ DCHECK(res_data.empty())
+ << "filter_by_selector requires the destination column to be
empty";
+ res_data.reserve(sel_size);
Review Comment:
为啥要reserve 后再resize
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
