HappenLee commented on code in PR #64010:
URL: https://github.com/apache/doris/pull/64010#discussion_r3371687568
##########
be/src/storage/segment/segment_iterator.cpp:
##########
@@ -586,6 +470,64 @@ Status SegmentIterator::_init_impl(const
StorageReadOptions& opts) {
return Status::OK();
}
+void SegmentIterator::_init_schema_block_id_map() {
+ _schema_block_id_map.assign(_schema->columns().size(), -1);
+ for (int i = 0; i < _schema->num_column_ids(); i++) {
+ auto cid = _schema->column_id(i);
+ _schema_block_id_map[cid] = i;
+ }
+}
+
+Status SegmentIterator::_init_project_schema() {
Review Comment:
这个函数除了Status是OK，就不会返回其他的异常状态，是不是void更合理
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
