github-actions[bot] commented on code in PR #61440: URL: https://github.com/apache/doris/pull/61440#discussion_r3365959208
########## fe/fe-authentication/fe-authentication-plugins/fe-authentication-plugin-ldap/src/test/java/org/apache/doris/authentication/plugin/ldap/LdapAuthenticationPluginIntegrationTest.java: ########## @@ -22,6 +22,7 @@ import org.apache.doris.authentication.AuthenticationResult; import org.apache.doris.authentication.CredentialType; import org.apache.doris.authentication.Principal; +import org.apache.doris.common.LdapConfig; Review Comment: This import makes the LDAP plugin module fail to compile. `fe-authentication-plugin-ldap/pom.xml` only declares the authentication API/SPI, Spring LDAP, logging, Guava, and test LDAP SDK dependencies, and neither this module nor its parent poms declare `fe-common`, which is where `org.apache.doris.common.LdapConfig` lives. Since the plugin code intentionally does not depend on the legacy FE `LdapConfig`, please either remove the `LdapConfig` references from this plugin test or add an explicit test-scoped dependency if that coupling is intended. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
