Mryange opened a new pull request, #64139:
URL: https://github.com/apache/doris/pull/64139

   ### What problem does this PR solve?
   
   Issue Number: N/A
   
   Problem Summary:
   
   Pipeline operator source and sink paths need a common place to validate 
output and input blocks. Before this change, `sink` and `get_block` were the 
virtual override points, so common validation either had to stay in call sites 
or be duplicated across operator implementations.
   
   Root cause: the public operator data-flow entry points were also the 
polymorphic implementation hooks, which left no wrapper layer for shared checks.
   
   This change makes `DataSinkOperatorXBase::sink` and 
`OperatorXBase::get_block` non-virtual wrappers. The wrappers run 
`Block::check_type_and_column()` at the source/sink boundary and then dispatch 
to the new virtual `sink_impl` and `get_block_impl` methods. All pipeline 
operator implementations, exchange operators, scan operators, and related BE 
test mocks are migrated to the new impl methods. The scan projection path is 
updated to call the base `get_block` wrapper so the shared checks still apply.
   
   
   ### Release note
   
   None
   
   ### Check List (For Author)
   
   - Test <!-- At least one of them must be included. -->
       - [ ] Regression test
       - [ ] Unit Test
       - [ ] Manual test (add detailed scripts or steps below)
       - [ ] No need to test or manual test. Explain why:
           - [ ] This is a refactor/code format and no logic has been changed.
           - [ ] Previous test can cover this change.
           - [ ] No code files have been changed.
           - [ ] Other reason <!-- Add your reason?  -->
   
   - Behavior changed:
       - [ ] No.
       - [ ] Yes. <!-- Explain the behavior change -->
   
   - Does this need documentation?
       - [ ] No.
       - [ ] Yes. <!-- Add document PR link here. eg: 
https://github.com/apache/doris-website/pull/1214 -->
   
   ### Check List (For Reviewer who merge this PR)
   
   - [ ] Confirm the release note
   - [ ] Confirm test cases
   - [ ] Confirm document
   - [ ] Add branch pick label <!-- Add branch pick label that this PR should 
merge into -->
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to