gavinchou commented on PR #64038: URL: https://github.com/apache/doris/pull/64038#issuecomment-4623312093
Addressed the review comments in ac67923b29f. - For github-actions: Cloud recycler S3/Azure paths now use the shared S3 local rate limiter accounting from common, expose the renamed sleep/rejected bvars, use sampled throttled/rejected logging, and record final 429 failures on non-success paths while excluding expected not-found handling. - For wyxxxcat: moved the shared S3 rate limiter metric/log helper into common/cpp/token_bucket_rate_limiter so BE and recycler use the same framework instead of separate BE-only logic. Validation: - Passed: sh run-cloud-ut.sh --run --filter=s3_rate_limiter_test:* - BE rerun note: sh run-be-ut.sh --run --filter=S3FileWriterTest.* is currently blocked before test execution by an unrelated third-party apache-orc/protobuf build error (PROTOBUF_* previously defined). The same command passed before these review fixes, and the current failure occurs while compiling contrib/apache-orc, not changed Doris sources. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
