eldenmoon commented on PR #64094: URL: https://github.com/apache/doris/pull/64094#issuecomment-4620200270
Addressed the latest blocking review and the `FunctionVariantCast.CastFromVariant` crash in `5bad3f7c38512`. Summary: - For `input_rows_count == 0`, `cast_from_variant_impl` now returns an empty target column before calling `ColumnVariant` helpers that assume non-empty rows. - Removed the invalid row-count guard that compared the requested semantic row count with `ColumnVariant::size()`. The reported crash used a root-only unfinalized Variant test column whose root has 3 rows while `ColumnVariant::size()` is 0. - Added `FunctionVariantCast.CastFromVariantZeroRowPrefixDoesNotFinalizeSourceColumn` covering string and JSONB zero-row prefix casts on non-empty unfinalized Variant input. Verified locally: - `./run-be-ut.sh --run --filter='FunctionVariantCast.CastFromVariant:FunctionVariantCast.CastFromVariantZeroRowPrefixDoesNotFinalizeSourceColumn:FunctionVariantCast.CastFromVariantJsonbPrefixDoesNotFinalizeSourceColumn:FunctionVariantCast.CastFromNullableVariantPrefixDoesNotFinalizeSourceColumn'` - `./run-be-ut.sh --run --filter='ColumnVariantTest.insert_range_from_materializes_pending_default_suffix:ColumnVariantTest.clone_finalized_deep_copies_columns:ColumnVariantTest.serialize_does_not_finalize_source_column:ColumnVariantTest.block_serialize_does_not_finalize_source_column:FunctionVariantCast.CastFromVariant:FunctionVariantCast.CastFromVariantDoesNotFinalizeSourceColumn:FunctionVariantCast.CastFromVariantJsonbPrefixDoesNotFinalizeSourceColumn:FunctionVariantCast.CastFromVariantZeroRowPrefixDoesNotFinalizeSourceColumn:FunctionVariantCast.CastFromFinalizedVariantJsonbPrefix:FunctionVariantCast.CastFromNullableVariantPrefixDoesNotFinalizeSourceColumn'` - `PATH=/mnt/disk1/claude-max/ldb_toolchain16/bin:$PATH build-support/clang-format.sh` - `git diff --check` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
