github-actions[bot] commented on code in PR #64101:
URL: https://github.com/apache/doris/pull/64101#discussion_r3353264059


##########
.github/CODEOWNERS:
##########
@@ -113,6 +113,8 @@ fe/fe-core/src/main/java/org/apache/doris/ha                
 @mymeiyi @gavinchou
 fe/fe-core/src/main/java/org/apache/doris/journal            @mymeiyi 
@gavinchou
 fe/fe-core/src/main/java/org/apache/doris/load               @liaoxin01 
@gavinchou
 fe/fe-core/src/main/java/org/apache/doris/master             @mymeiyi 
@deardeng @gavinchou
+fe/fe-core/src/main/java/org/apache/doris/mtmv               @morrySnow 
@seawinde
+fe/fe-core/src/main/java/org/apache/doris/nereids            @morrySnow 
@924060929 @englefly @starocean999
 fe/fe-core/src/main/java/org/apache/doris/persist            @mymeiyi 
@gavinchou

Review Comment:
   These new rules cover the main MTMV and Nereids source packages, but the 
corresponding FE unit-test packages are still uncovered: 
`fe/fe-core/src/test/java/org/apache/doris/mtmv` and 
`fe/fe-core/src/test/java/org/apache/doris/nereids`. This means a PR that only 
changes optimizer/MTMV tests will not request these owners, which makes the 
CODEOWNERS coverage incomplete for the same components. Please add matching 
test-directory entries near the existing `fe/fe-core/src/test/java/...` block.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to